Config cleanup #1903
Config cleanup #1903
Conversation
ruflin
commented
Jun 24, 2016
•
ruflin
commented
- Code cleanup
- Add humanize for buffersize
ruflin
added
in progress
ruflin
added
review
and removed
in progress
ruflin
force-pushed
the
config-cleanup
branch
2 times, most recently
from
112383d to
c07e922
Compare
| @@ -22,7 +22,9 @@ type Filebeat struct { | |||
|
|
|||
| // New creates a new Filebeat pointer instance. | |||
| func New() *Filebeat { | |||
| return &Filebeat{} | |||
| return &Filebeat{ | |||
| config: &cfg.DefaultConfig, | |||
There was a problem hiding this comment.
don't take the default config as pointer. DefaultConfig normally serves as template to be copied and must not contain any pointers!
Rather allocate new config initialized with DefaultConfig like:
config := cfg.DefaultConfig
return &Filebeat{ config: &config }
|
@urso New version pushed. |
| PublishAsync bool `config:"publish_async"` | ||
| IdleTimeout time.Duration `config:"idle_timeout"` | ||
| IdleTimeout time.Duration `config:"idle_timeout" validate:"nonzero,min=0"` |
There was a problem hiding this comment.
what if I want to disable idle_time, e.g. via -1 or 0?
There was a problem hiding this comment.
Not sure if that is something that we should encourage. That above allows to set it for example to 0.001s which is almost like disabling it.
One thing I just realised related to duration and ucfg: it should be min=1s and not min=1 as if the unit is not know, it could be "anything".
There was a problem hiding this comment.
that's right. if not setting any unit, the default is 's'. But normally I set units.
There was a problem hiding this comment.
but in past `idle_timeout' was disablable, no?
There was a problem hiding this comment.
@urso didn't know it allows to set units there. Nice :-) Will add units.
There was a problem hiding this comment.
default before (and now) is 5s
* Code cleanup * Add humanize for buffersize
